Fixed [0.45.1] Surf Sprite Bug

[Tornado9797]

Upon exiting a wild battle while Surfing, you return back to your land sprite:

 

[Darkfire]

Upon exiting a wild battle while Surfing, you return back to your land sprite:
View attachment 4246

The fact that you use a pokemon as your sprite had me so confused...

 

[Tornado9797]

The fact that you use a pokemon as your sprite had me so confused...

Well you of all people should know I'm not implemented yet.

 

[Darkfire]

Well you of all people should know I'm not implemented yet.

Yeah but still

 

[nilllzz]

I cannot reproduce that...
Can you provide a step by step guide?

 

[Tornado9797]

I cannot reproduce that...
Can you provide a step by step guide?

1. I used Surf on New Bark Town's coast en route to Kanto Route 27.
2. 5 or so squares after Surfing, I am challenged by a wild Tentacruel.
3. When the battle was over, I was no longer using my Surfing sprite.

 

[nilllzz]

So you have been able to reproduce it...

 

[Tornado9797]

So you have been able to reproduce it...

Well actually no, I have not, I just recalled what happened when I managed to execute the bug.

I have not encountered the bug since then, and I cannot exactly test for reproduction right now (not at home).

 

[AlbusRabbit]

I seemed to have the same issue yesterday, was at night and was tired so I didn't screenshot it but if it happens again I will take a picture, it seems to happen whenever I switch maps while in surf though.

 

[Tornado9797]

I seemed to have the same issue yesterday, was at night and was tired so I didn't screenshot it but if it happens again I will take a picture, it seems to happen whenever I switch maps while in surf though.

That might be the issue, because this happened to me on the New Bark Town/Route 27 border.

 

[Miragics]

In sandboxmode, you can change your skin with a similiar issue. You can use a Pokemon to surf, then reload the map and next time you walk on land your new sprite is the pokemon that used surf.

 

[nilllzz]

The Surf function used outdated code. I fixed it.

 

[nilllzz]

In sandboxmode, you can change your skin with a similiar issue. You can use a Pokemon to surf, then reload the map and next time you walk on land your new sprite is the pokemon that used surf.

That is because you are not surfing anymore when you are reloading the map using sandbox mode.
When you then start to surf again, you still have the surf sprite. The game stores the current sprite in a temp storage, to recall it later. At the moment, your overworld sprite is stored in there. But when you then start surfing again, it overwrites that sprite with your current sprite, which is the Pokémon you used for surfing before reloading the map.
So now, you have a Pokémon sprite in that temp storage while also having that sprite on your player. Once you go to land, the temp storage sprite will load and overwrite the current sprite. So you get the Pokémon sprite from the temp storage as default.
That issue will only apply in sandbox mode, so I won't fix it. You can easily change your sprite back when you are in sandbox mode anyway.